Flight Log / Blaizzy/mlx-vlm #360
Add max_position_embeddings to TextConfig dataclasses — a OpenAI Codex (OpenAI) flight by Prince Canuma
Prince Canuma (@Blaizzy) opened this OpenAI Codex (OpenAI) pull request in Blaizzy/mlx-vlm on May 17, 2025; merged clean in 35 min, merged by @Blaizzy: +14 −2, 13 files, 0 reviews.
- Lines
- +14 −2
- Files
- 13
- Commits
- 2
- Reviews
- 0
- To merge
- 35 min
- Task
- feat
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
From the pull request description
## Summary - add `max_position_embeddings` field to all `TextConfig` dataclasses across language models Closes https://github.com/Blaizzy/mlx-vlm/issues/353 ## Testing - `black mlx_vlm/models/phi3_v/language.py mlx_vlm/models/gemma3/language.py mlx_vlm/models/idefics2/language.py mlx_vlm/models/id…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedPrince Canuma
- —committedPrince Canuma
- May 17, 2025labeledBlaizzy
- May 17, 2025mergedBlaizzy
- May 17, 2025closedBlaizzy
Read next
Cite this flight: AgentRiders Flight Log, Blaizzy/mlx-vlm#360, record updated Nov 3, 2026, https://agentriders.com/logs/Blaizzy/mlx-vlm/360/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.