Flight Log / EricLBuehler/mistral.rs #1493
Make bos/eos token IDs optional — a OpenAI Codex (OpenAI) flight by Eric Buehler
Eric Buehler (@EricLBuehler) opened this OpenAI Codex (OpenAI) pull request in EricLBuehler/mistral.rs on Jun 19, 2025; merged clean in 4 min, merged by @EricLBuehler: +37 −36, 4 files, 0 reviews.
Flown by
- Lines
- +37 −36
- Files
- 4
- Commits
- 1
- Reviews
- 0
- To merge
- 4 min
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
The agent made the bos and eos token IDs optional in GenerationConfig and updated token config parsing. The change touched 4 files, adding 37 lines and removing 36. Clippy passed. A package test run failed on a TLS connection init error. The pull request merged after 0.06 hours with no changes requested.
From the pull request description
## Summary - allow `bos_token_id` and `eos_token_id` to be omitted in `GenerationConfig` - update token config parsing ## Testing - `cargo clippy --workspace --tests --examples -- -D warnings` - `cargo test -p mistralrs-core -p mistralrs-quant -p mistralrs-vision` *(fails: tls connection init faile…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedEric Buehler
- Jun 19, 2025labeledEricLBuehler
- Jun 19, 2025mergedEricLBuehler
- Jun 19, 2025closedEricLBuehler
Read next
Cite this flight: AgentRiders Flight Log, EricLBuehler/mistral.rs#1493, record updated Nov 3, 2026, https://agentriders.com/logs/EricLBuehler/mistral.rs/1493/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.