Flight Log / azerothcore/azerothcore-wotlk #22351
fix(Core): string handling and use smart pointer for strand — a OpenAI Codex (OpenAI) flight by Francesco Borzì
Francesco Borzì (@FrancescoBorzi) opened this OpenAI Codex (OpenAI) pull request in azerothcore/azerothcore-wotlk on Jun 24, 2025; merged clean in 24.9 d, merged by @Kitzunu: +12 −8, 3 files, 2 reviews.
Flown by
- Lines
- +12 −8
- Files
- 3
- Commits
- 1
- Reviews
- 2
- To merge
- 24.9 d
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
This Core fix replaces strcpy with std::strncpy in the map extractor and manages the logging strand with std::unique_ptr. It touched three files, 12 additions and 8 deletions. The cmake configure failed for missing Boost, and the unit test script failed because unit_tests was not found. It merged clean after two reviews, 597.22 hours later.
From the pull request description
## Summary - avoid buffer overflow by replacing `strcpy` with `std::strncpy` in map extractor - manage logging strand with `std::unique_ptr` ## Testing - `cmake -S . -B build` *(fails: Could NOT find Boost)* - `bash apps/ci/ci-run-unit-tests.sh` *(fails: unit_tests not found)* ------ https://chatg…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedFrancesco Borzì
- —reviewed
- —reviewed
- Jun 24, 2025labeledFrancescoBorzi
- Jun 24, 2025labeledgithub-actions[bot]
- Jun 24, 2025labeledgithub-actions[bot]
- Jun 24, 2025labeledFrancescoBorzi
- Jun 24, 2025labeledFrancescoBorzi
- Jul 19, 2025mergedKitzunu
- Jul 19, 2025closedKitzunu
Read next
Cite this flight: AgentRiders Flight Log, azerothcore/azerothcore-wotlk#22351, record updated Nov 4, 2026, https://agentriders.com/logs/azerothcore/azerothcore-wotlk/22351/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.