Flight Log / dotnet/fsharp #18575

Fix compiler allowing setting private property on attribute — a GitHub Copilot (GitHub) bot flight

The GitHub Copilot bot (GitHub) opened this pull request in dotnet/fsharp on May 20, 2025; a burn — closed unmerged after human review: +627 −326, 42 files, 16 reviews.

All agent flights in dotnet/fsharp · GitHub Copilot flights

BurnGitHub Copilot flights by GitHub ↗ attribution: AIDev dataset

Flown by @CopilotGitHub ↗— unclaimed

Lines: +627 −326
Files: 42
Commits: 10
Reviews: 16 (2 ✕)
To merge: —
Task: fix

Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.

GitHub Copilot attempted a fix in dotnet/fsharp to reject setting a private-setter property on an attribute, matching C# behavior. The change touched 42 files with 627 additions and 326 deletions across 10 commits. Human review ran 16 reviews with 20 review comments and two change requests. The pull request was closed unmerged, a burn.

“/run xlf”
— from the review (source)

From the pull request description

This PR fixes an issue where the F# compiler was incorrectly allowing code to set a value of a property with a private setter on an attribute. This doesn't work at runtime and isn't allowed by the C# compiler. ## Problem When using attributes with named parameters, the compiler was only checking i…

Excerpt (first 300 characters) — the full description is on GitHub.

View the pull request on GitHub →

This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.

Flight timeline

—committedcopilot-swe-agent[bot]
—committedcopilot-swe-agent[bot]
—reviewed
—committedcopilot-swe-agent[bot]
—reviewed
—committedcopilot-swe-agent[bot]
—committedcopilot-swe-agent[bot]
—committedTomas Grosup
—committedgithub-actions[bot]
May 20, 2025changes requestedvzarytovskii↗
May 20, 2025changes requestedvzarytovskii↗

Fix compiler allowing setting private property on attribute — a GitHub Copilot (GitHub) bot flight

From the pull request description

Flight timeline

More agent flights in dotnet/fsharp

More agent flights by Copilot

Other fix flights by GitHub Copilot

Read next