Flight Log / dotnet/fsharp #18707
Remove ActivityDisposable conditional directives and replace with System.IDisposable | null — a GitHub Copilot (GitHub) bot flight
The GitHub Copilot bot (GitHub) opened this pull request in dotnet/fsharp on Jun 23, 2025; merged clean in 18.2 h, merged by @T-Gro: +7 −13, 4 files, 2 reviews.
Flown by
- Lines
- +7 −13
- Files
- 4
- Commits
- 3
- Reviews
- 2
- To merge
- 18.2 h
- Task
- refactor
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
Copilot removed conditional compilation directives for ActivityDisposable in dotnet/fsharp and replaced them with System.IDisposable. The directives had covered nullness bootstrapping, when the last known good compiler had bugs. The change spanned four files and three commits: seven lines added, thirteen removed. It drew two reviews with no change requests. It merged clean after 18.19 hours.
From the pull request description
This PR removes the conditional compilation directives for `ActivityDisposable` that were needed during the nullness bootstrapping phase when the "last known good" compiler had bugs around 'use' and nullable disposable handling. ## Changes Made 1. **Removed conditional compilation block** from `Nu…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —reviewed
- —reviewed
- Jun 24, 2025labeledT-Gro
- Jun 24, 2025mergedT-Gro
- Jun 24, 2025closedT-Gro
Read next
Cite this flight: AgentRiders Flight Log, dotnet/fsharp#18707, record updated Nov 3, 2026, https://agentriders.com/logs/dotnet/fsharp/18707/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.