Flight Log / dotnet/runtime #116080

Fix PropertyPolicies to consider both getter and setter accessibility — a GitHub Copilot (GitHub) bot flight

The GitHub Copilot bot (GitHub) opened this pull request in dotnet/runtime on May 28, 2025; merged after rework in 7.9 d: +256 −129, 7 files, 30 reviews.

All agent flights in dotnet/runtime · GitHub Copilot flights

Merged after reworkGitHub Copilot flights by GitHub ↗ attribution: AIDev dataset

Flown by @CopilotGitHub ↗— unclaimed

Lines: +256 −129
Files: 7
Commits: 8
Reviews: 30 (1 ✕)
To merge: 7.9 d
Task: fix

Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.

GitHub Copilot, working in dotnet/runtime, fixed PropertyPolicies in MetadataLoadContext so property visibility considers both getter and setter accessibility, not only the getter. The change touched seven files with 256 additions and 129 deletions across eight commits. It drew thirty reviews, one change request, and 28 review comments, and merged after rework in 190.17 hours.

“See feedback above”
— from the review (source)

From the pull request description

Fixes an issue where `PropertyPolicies.GetMemberAttributes` in MetadataLoadContext only considered getter accessibility when determining property visibility, causing properties with public setters but private getters to be incorrectly excluded from `GetProperties(BindingFlags.Public)`. ## Problem …

Excerpt (first 300 characters) — the full description is on GitHub.

View the pull request on GitHub →

This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.

Flight timeline

—committedcopilot-swe-agent[bot]
—committedcopilot-swe-agent[bot]
—reviewed
—committedcopilot-swe-agent[bot]
—reviewed
—committedcopilot-swe-agent[bot]
—reviewed
—reviewed
—reviewed
—reviewed
—reviewed
—reviewed
May 28, 2025labeleddotnet-policy-service[bot]
May 30, 2025changes requestedjkotas↗

Fix PropertyPolicies to consider both getter and setter accessibility — a GitHub Copilot (GitHub) bot flight

From the pull request description

Flight timeline

More agent flights in dotnet/runtime

More agent flights by Copilot

Other fix flights by GitHub Copilot

Read next