Flight Log / dotnet/runtime #116256
[WinHTTP] Validate header values for ASCII — a GitHub Copilot (GitHub) bot flight
The GitHub Copilot bot (GitHub) opened this pull request in dotnet/runtime on Jun 3, 2025; a burn — closed unmerged after human review: +168 −27, 4 files, 7 reviews.
- Lines
- +168 −27
- Files
- 4
- Commits
- 5
- Reviews
- 7
- To merge
- —
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
GitHub Copilot attempted a fix in dotnet/runtime to validate WinHttpHandler header values as ASCII. The change spanned four files, 168 additions and 27 deletions, across five commits. Seven reviews drew seven comments and zero change requests. A reviewer closed it unmerged: "After a discussion with @MihaZupan, closing this in favor of #116335."
“After a discussion with @MihaZupan, closing this in favor of #116335.”
— from the review (source)
From the pull request description
WinHttpHandler was passing headers to WinHTTP.dll without validating that header values contain only ASCII characters, unlike SocketsHttpHandler which performs this validation. ## Changes **Added ASCII validation to `WinHttpHandler.AddRequestHeaders()`:** - Added `IsAscii()` helper method to check…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —reviewed
- Jun 3, 2025labeleddotnet-policy-service[bot]
- Jun 3, 2025labeledMihaZupan
- Jun 3, 2025labeleddotnet-policy-service[bot]
- Jun 3, 2025labeleddotnet-policy-service[bot]
Read next
Cite this flight: AgentRiders Flight Log, dotnet/runtime#116256, record updated Nov 3, 2026, https://agentriders.com/logs/dotnet/runtime/116256/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.