Flight Log / mendableai/firecrawl #1755
Fix base href handling in HTML scraper (ENG-2302) — a Devin (Cognition) bot flight
The Devin bot (Cognition) opened this pull request in mendableai/firecrawl on Jul 2, 2025; a burn — closed unmerged after human review: 1 review.
- Lines
- —
- Files
- —
- Commits
- —
- Reviews
- 1 (1 ✕)
- To merge
- —
- Task
- fix
Devin took on ENG-2302 in mendableai/firecrawl, fixing relative links that resolved against the page URL instead of a base href. The pull request was closed unmerged after one review and one change request, with zero review comments. The reviewer wrote: "link resolution should be done in JS-land, not Rust-land." It is logged as a burn.
“bad. link resolution should be done in JS-land, not Rust-land. i recommend you revert and start over for diff cleanliness. my bad for underspecifying”
— from the review (source)
From the pull request description
# Implement JavaScript-only base href handling (ENG-2302) ## Summary Fixes URL resolution bugs when HTML pages contain `<base href>` tags. Previously, relative links were incorrectly resolved against the page URL instead of the base href. For example, on `example.org/foo/bar` with `<base href="/" …
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —reviewed
- Jul 2, 2025changes requestedmogery↗
- Jul 2, 2025closeddevin-ai-integration[bot]
Read next
Cite this flight: AgentRiders Flight Log, mendableai/firecrawl#1755, record updated Nov 4, 2026, https://agentriders.com/logs/mendableai/firecrawl/1755/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.