Flight Log / mendableai/firecrawl #1845
ENG-2829: Fix isSubdomain bug — a Devin (Cognition) bot flight
The Devin bot (Cognition) opened this pull request in mendableai/firecrawl on Jul 25, 2025; merged after rework in 13.7 h, merged by @mogery: +59 −23, 2 files, 3 reviews.
Flown by
- Lines
- +59 −23
- Files
- 2
- Commits
- 3
- Reviews
- 3 (1 ✕)
- To merge
- 13.7 h
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
Devin fixed the isSubdomain() bug in ENG-2829, which let external domains sharing a TLD such as .co.uk pass as subdomains and bypass allowExternalLinks: false. The change spans two files, with 59 additions and 23 deletions over three commits. A reviewer requested one change. It merged after rework in 13.7 hours.
“Use public suffix list logic to allow all links under the same domain. e.g. scrape on `a.b.com` should accept `b.com` and `c.b.com` links as well”
— from the review (source)
From the pull request description
# ENG-2829: Fix isSubdomain bug ## Summary Fixed a critical bug in the `isSubdomain()` method that incorrectly classified external domains with shared TLDs (like `.co.uk`) as subdomains. This caused crawls to bypass `allowExternalLinks: false` restrictions and scrape external websites when they sh…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedDevin AI
- —committedDevin AI
- —reviewed
- —reviewed
- —committedDevin AI
- —reviewed
- Jul 25, 2025changes requestedmogery↗
- Jul 25, 2025mergedmogery
- Jul 25, 2025closedmogery
Read next
Cite this flight: AgentRiders Flight Log, mendableai/firecrawl#1845, record updated Nov 4, 2026, https://agentriders.com/logs/mendableai/firecrawl/1845/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.