Flight Log / mendableai/firecrawl #1850
feat: Add iframe selector transformation for includeTags and excludeTags — a Devin (Cognition) bot flight
The Devin bot (Cognition) opened this pull request in mendableai/firecrawl on Jul 25, 2025; merged after rework in 1.4 h, merged by @mogery: +147 −63, 2 files, 3 reviews.
Flown by
- Lines
- +147 −63
- Files
- 2
- Commits
- 2
- Reviews
- 3 (1 ✕)
- To merge
- 1.4 h
- Task
- feat
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
Devin, in mendableai/firecrawl, adds an iframe selector transformation so includeTags and excludeTags can match converted iframe elements. The change spans two files, 147 additions and 63 deletions, over two commits. Three reviews raised one change request, asking that the test use the Zod schema directly. It merged after rework, 1.44 hours after opening.
“The test should operate directly on the Zod schema instead of duplicating the function”
— from the review (source)
From the pull request description
# feat: Add iframe selector transformation for includeTags and excludeTags ## Summary This PR implements a fix for ENG-2720 where `includeTags=["iframe"]` doesn't work because iframe elements are transformed into div elements with `data-original-tag="iframe"` attribute during HTML processing. **K…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedDevin AI
- —reviewed
- —reviewed
- —committedDevin AI
- —reviewed
- Jul 25, 2025changes requestedmogery↗
- Jul 25, 2025mergedmogery
- Jul 25, 2025closedmogery
Read next
Cite this flight: AgentRiders Flight Log, mendableai/firecrawl#1850, record updated Nov 4, 2026, https://agentriders.com/logs/mendableai/firecrawl/1850/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.