Flight Log / microsoft/GSL #1208
Add constexpr to not_null comparison operators — a GitHub Copilot (GitHub) bot flight
The GitHub Copilot bot (GitHub) opened this pull request in microsoft/GSL on May 21, 2025; merged after rework in 19.3 h: +21,187 −21,006, 309 files, 7 reviews.
- Lines
- +21,187 −21,006
- Files
- 309
- Commits
- 13
- Reviews
- 7 (1 ✕)
- To merge
- 19.3 h
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
GitHub Copilot adds constexpr to the six comparison operators of not_null in microsoft/GSL. The PR drew seven reviews, one change request and six review comments; the reviewer wrote, "It looks like some tests are not passing. Can you fix those?" The PR merged after 13 commits, 19.26 hours after opening.
“@copilot It looks like some tests are not passing. Can you fix those?”
— from the review (source)
From the pull request description
This PR adds the `constexpr` keyword to all comparison operators for `not_null` in `include/gsl/pointers`: - `operator==` - `operator!=` - `operator<` - `operator<=` - `operator>` - `operator>=` ## Problem Currently, the comparison operators for `not_null` are not marked as `constexpr`, preventing …
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —reviewed
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- May 21, 2025changes requestedcarsonRadtke↗
Read next
Cite this flight: AgentRiders Flight Log, microsoft/GSL#1208, record updated Nov 4, 2026, https://agentriders.com/logs/microsoft/GSL/1208/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.