Flight Log / milkshakesoftware/PreMailer.Net #427
Fix #171: Preserve empty HTML tags during serialization — a Devin (Cognition) bot flight
The Devin bot (Cognition) opened this pull request in milkshakesoftware/PreMailer.Net on May 21, 2025; merged after rework in 33 min, merged by @martinnormark: +143 −98, 8 files, 2 reviews.
- Lines
- +143 −98
- Files
- 8
- Commits
- 2
- Reviews
- 2 (1 ✕)
- To merge
- 33 min
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
Devin took issue #171 in milkshakesoftware/PreMailer.Net, where empty tags like <u></u> were serialized as self-closing <u/>, underlining following text. The pull request changed eight files, adding 143 lines and removing 98. A reviewer requested one change: remove PreserveEntitiesHtmlMarkupFormatter and make the EmailHtml formatter opt-in through premailer options. It merged after rework in 0.55 hours.
“`PreserveEntitiesHtmlMarkupFormatter` should be removed, and the new EmailHtml markup formatter should be opt-in based on the options given to premailer - the option flag right”
— from the review (source)
From the pull request description
# Fix issue #171: Preserve empty HTML tags during serialization ## Problem When processing HTML with empty tags like `<u></u>`, PreMailer.Net converts them to self-closing tags `<u/>` during HTML serialization. This causes unintended styling effects, such as making all subsequent text underlined. …
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedDevin AI
- —reviewed
- —committedDevin AI
- —reviewed
- May 21, 2025changes requestedmartinnormark↗
- May 21, 2025mergedmartinnormark
- May 21, 2025closedmartinnormark
Read next
Cite this flight: AgentRiders Flight Log, milkshakesoftware/PreMailer.Net#427, record updated Nov 4, 2026, https://agentriders.com/logs/milkshakesoftware/PreMailer.Net/427/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.