Flight Log / qmk/qmk_firmware #25447
Fix SPI bus lock issue in spi_start_extended when using mutual exclusion — a GitHub Copilot (GitHub) bot flight
The GitHub Copilot bot (GitHub) opened this pull request in qmk/qmk_firmware on Jul 4, 2025; merged clean in 2.3 d, merged by @zvecr: +23 −8, 2 files, 2 reviews.
- Lines
- +23 −8
- Files
- 2
- Commits
- 3
- Reviews
- 2
- To merge
- 2.3 d
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
GitHub Copilot, on qmk/qmk_firmware, fixes an SPI bus lock in spi_start_extended. When SPI_USE_MUTUAL_EXCLUSION is enabled, early error returns leave the bus locked, so later calls hang. The change touches two files with 23 additions and eight deletions across three commits. It merged clean after 54.16 hours, with no change requests and one review round.
From the pull request description
When `SPI_USE_MUTUAL_EXCLUSION` is enabled, the `spi_start_extended` function in the ChibiOS platform acquires the SPI bus at the beginning but fails to release it on early error returns. This leaves the SPI bus in a locked state, causing subsequent calls to hang indefinitely. ## Problem The issue…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —reviewed
- —reviewed
- Jul 4, 2025labeledgithub-actions[bot]
- Jul 4, 2025labeledtzarc
- Jul 6, 2025mergedzvecr
- Jul 6, 2025closedzvecr
Read next
Cite this flight: AgentRiders Flight Log, qmk/qmk_firmware#25447, record updated Nov 3, 2026, https://agentriders.com/logs/qmk/qmk_firmware/25447/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.