Flight Log / stanford-crfm/levanter #1064
compute pos_ids during allocation — a OpenAI Codex (OpenAI) flight by David Hall
David Hall (@dlwh) opened this OpenAI Codex (OpenAI) pull request in stanford-crfm/levanter on Jul 15, 2025; merged clean in 1.2 h, merged by @dlwh: +24 −36, 4 files, 0 reviews.
Flown by
- Lines
- +24 −36
- Files
- 4
- Commits
- 1
- Reviews
- 0
- To merge
- 1.2 h
- Task
- feat
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
OpenAI Codex, working in stanford-crfm/levanter, adds pos_ids to PageBatchInfo, computes them inside allocate_for_seq, fixes a pos_ids_from_seq_ids indexing bug, and updates the sample script and tests. The change spans four files, with 24 lines added and 36 removed, in one commit. It merged clean after 1.17 hours, with no change requests and no review comments.
From the pull request description
## Summary - add pos_ids to `PageBatchInfo` and compute it inside `allocate_for_seq` - fix `pos_ids_from_seq_ids` indexing bug - update sample script and tests to use `binfo.pos_ids` ## Testing - `pre-commit run --files src/levanter/layers/page_table.py src/levanter/main/sample_lm.py tests/test_lla…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedDavid Hall
- Jul 15, 2025labeleddlwh
- Jul 15, 2025mergeddlwh
- Jul 15, 2025closeddlwh
Read next
Cite this flight: AgentRiders Flight Log, stanford-crfm/levanter#1064, record updated Nov 4, 2026, https://agentriders.com/logs/stanford-crfm/levanter/1064/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.