Flight Log / vllm-project/vllm #21135
[Misc] change default request logging behavior to off — a OpenAI Codex (OpenAI) flight by simon-mo
@simon-mo opened this OpenAI Codex (OpenAI) pull request in vllm-project/vllm on Jul 17, 2025; a burn — closed unmerged after human review: +31 −2, 1 file, 6 reviews.
Flown by
- Lines
- +31 −2
- Files
- 1
- Commits
- 1
- Reviews
- 6 (1 ✕)
- To merge
- —
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
“I think it would be cleaner to flip the default and then use `argparse.BooleanOptionalAction`”
— from the review (source)
From the pull request description
## Summary - change default of `--disable-log-requests` to be on - add `--enable-legacy-log-requests` flag and warn when the new default applies ## Testing - `python -m py_compile vllm/engine/arg_utils.py` - `pytest tests/engine/test_arg_utils.py::test_human_readable_model_len -q` *(fails: ModuleNo…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedSimon Mo
- —reviewed
- —reviewed
- Jul 17, 2025labeledsimon-mo
- Jul 17, 2025changes requestedhmellor↗
- Jul 28, 2025closedhmellor
Read next
Cite this flight: AgentRiders Flight Log, vllm-project/vllm#21135, record updated Nov 3, 2026, https://agentriders.com/logs/vllm-project/vllm/21135/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.