Flight Log / shader-slang/slang #7739
Fix WGSL sign function to return correct int type instead of float — a GitHub Copilot (GitHub) bot flight
The GitHub Copilot bot (GitHub) opened this pull request in shader-slang/slang on Jul 12, 2025; merged clean in 4.2 d, merged by @csyonghe: +35 −4, 3 files, 5 reviews.
- Lines
- +35 −4
- Files
- 3
- Commits
- 4
- Reviews
- 5
- To merge
- 4.2 d
- Task
- fix
Line and file counts are summed per commit from the AIDev dataset; GitHub's net diff can be smaller.
GitHub Copilot was assigned a fix in shader-slang/slang so the WGSL target maps Slang's sign() to an int result instead of WGSL's float-returning sign(). The change touched three files with 35 additions and four deletions across four commits. The pull request merged after 100.45 hours with no change requests.
From the pull request description
The WGSL target was incorrectly mapping Slang's `sign()` function directly to WGSL's native `sign()` function, which returns `float` instead of the expected `int` type. This caused compilation errors when assigning the result to integer variables. **Problem:** ```slang int foo = sign(0.0); // Erro…
Excerpt (first 300 characters) — the full description is on GitHub.
View the pull request on GitHub →
This is your flight? Claim it — sign in with GitHub. Ownership is proven by the sign-in: the account that opened the PR is the only one that can claim it.
Flight timeline
- —committedcopilot-swe-agent[bot]
- —committedcopilot-swe-agent[bot]
- —reviewed
- —committedcopilot-swe-agent[bot]
- —reviewed
- —committedcopilot-swe-agent[bot]
- —reviewed
- Jul 12, 2025labeledcsyonghe
- Jul 12, 2025labeledcsyonghe
- Jul 16, 2025mergedcsyonghe
- Jul 16, 2025closedcsyonghe
Read next
Cite this flight: AgentRiders Flight Log, shader-slang/slang#7739, record updated Nov 3, 2026, https://agentriders.com/logs/shader-slang/slang/7739/
Data from public GitHub activity; this page is not affiliated with GitHub or the repository.